Save point #5

Author: cmcnally-r7

plugins/cisco_umbrella_destinations/unit_test/mock.py

@@ -24,7 +24,7 @@ def __init__(self, filename: str, status_code: int, text: str = "") -> None:
 
     def json(self):
         with open(
-            os.path.join(os.path.dirname(os.path.realpath(__file__)), f"responses/{self.filename}.json.resp")
+                os.path.join(os.path.dirname(os.path.realpath(__file__)), f"responses/{self.filename}.json.resp")
         ) as file:
             return json.load(file)
 
@@ -35,7 +35,6 @@ def mocked_request(side_effect: Callable) -> None:
 
 
 def mock_conditions(method: str, url: str, status_code: int) -> MockResponse:
-    print(method, url, status_code)
     base_url = f"https://management.api.umbrella.com/v1/organizations/{STUB_ORG_ID}/destinationlists"
     if url == base_url:
         if method == "GET":
@@ -74,5 +73,9 @@ def mock_request_403(*args, **kwargs) -> MockResponse:
     return mock_conditions(args[0], args[1], 403)
 
 
+def mock_request_404(*args, **kwargs) -> MockResponse:
+    return mock_conditions(args[0], args[1], 403)
+
+
 def mock_request_500(*args, **kwargs) -> MockResponse:
     return mock_conditions(args[0], args[1], 500)

plugins/cisco_umbrella_destinations/unit_test/test_dlCreate.py

@@ -1,15 +1,27 @@
 import sys
 import os
 
+from parameterized import parameterized
+
 sys.path.append(os.path.abspath("../"))
 
 from unittest import TestCase, mock
 from icon_cisco_umbrella_destinations.connection.connection import Connection
 from icon_cisco_umbrella_destinations.actions.dlCreate import DlCreate
 from icon_cisco_umbrella_destinations.actions.dlCreate.schema import Input
-import json
+from insightconnect_plugin_runtime.exceptions import PluginException
 import logging
-from unit_test.mock import STUB_CONNECTION, mock_request_200, STUB_DESTINATION_LIST_ID
+from unit_test.mock import (
+    STUB_CONNECTION,
+    mock_request_200,
+    mock_request_403,
+    mock_request_401,
+    mock_request_500,
+    mock_request_400,
+    mock_request_404,
+    STUB_DESTINATION_LIST_ID,
+    mocked_request,
+)
 
 
 class TestDlCreate(TestCase):
@@ -28,21 +40,18 @@ def setUp(self) -> None:
             "name": "DELETEME2",
         }
 
+        self.params = {Input.ACCESS: "allow", Input.ISGLOBAL: False, Input.LABEL: "DELETEME2"}
+
     @mock.patch("requests.request", side_effect=mock_request_200)
     def test_successful(self, mock_post):
-        response = self.action.run({
-            Input.ACCESS: 'allow',
-            Input.ISGLOBAL: False,
-            Input.LABEL: 'DELETEME2'
-        })
+        response = self.action.run({Input.ACCESS: "allow", Input.ISGLOBAL: False, Input.LABEL: "DELETEME2"})
         expected_response = {
             "success": {
                 "id": 15786904,
                 "organizationId": 2372338,
                 "access": "allow",
                 "isGlobal": False,
                 "name": "DELETEME2",
-                "thirdpartyCategoryId": None,
                 "createdAt": "2022-02-10T11:01:20+0000",
                 "modifiedAt": "2022-02-10T11:01:20+0000",
                 "isMspDefault": False,
@@ -52,3 +61,18 @@ def test_successful(self, mock_post):
             }
         }
         self.assertEqual(response, expected_response)
+
+    @parameterized.expand(
+        [
+            (mock_request_401, PluginException.Preset.USERNAME_PASSWORD),
+            (mock_request_403, PluginException.Preset.UNAUTHORIZED),
+            (mock_request_404, PluginException.Preset.UNAUTHORIZED),
+            (mock_request_500, PluginException.Preset.SERVER_ERROR),
+        ],
+    )
+    def test_not_ok(self, mock_request, exception):
+        mocked_request(mock_request)
+
+        with self.assertRaises(PluginException) as context:
+            self.action.run(self.params)
+        self.assertEqual(context.exception.cause, PluginException.causes[exception])

plugins/cisco_umbrella_destinations/unit_test/test_dlGet.py

@@ -1,16 +1,27 @@
 import sys
 import os
+from parameterized import parameterized
 
 sys.path.append(os.path.abspath("../"))
 
 from unittest import TestCase, mock
 from icon_cisco_umbrella_destinations.connection.connection import Connection
 from icon_cisco_umbrella_destinations.actions.dlGet import DlGet
 from icon_cisco_umbrella_destinations.actions.dlGet.schema import Input
-import json
+from insightconnect_plugin_runtime.exceptions import PluginException
 import logging
 
-from unit_test.mock import STUB_CONNECTION, mock_request_200, STUB_DESTINATION_LIST_ID
+from unit_test.mock import (
+    STUB_CONNECTION,
+    mock_request_200,
+    mock_request_403,
+    mock_request_401,
+    mock_request_500,
+    mock_request_400,
+    mock_request_404,
+    STUB_DESTINATION_LIST_ID,
+    mocked_request,
+)
 
 
 class TestDlGet(TestCase):
@@ -48,3 +59,18 @@ def test_destination_list_get_success(self, mock_get):
             }
         }
         self.assertEqual(response, expected_response)
+
+    @parameterized.expand(
+        [
+            (mock_request_401, PluginException.Preset.USERNAME_PASSWORD),
+            (mock_request_403, PluginException.Preset.UNAUTHORIZED),
+            (mock_request_404, PluginException.Preset.UNAUTHORIZED),
+            (mock_request_500, PluginException.Preset.SERVER_ERROR),
+        ],
+    )
+    def test_not_ok(self, mock_request, exception):
+        mocked_request(mock_request)
+
+        with self.assertRaises(PluginException) as context:
+            self.action.run({Input.DESTINATIONLISTID: STUB_DESTINATION_LIST_ID})
+        self.assertEqual(context.exception.cause, PluginException.causes[exception])