Conversation
vcidst
requested review from
a team,
ancalita and
radovanZRasa
and removed request for
a team
ancalita
reviewed
Jan 19, 2024
|
|
||
| return parse_data | ||
|
|
||
| def _update_full_retrieval_intent(self, parse_data: Dict[Text, Any]) -> None: |
Member
There was a problem hiding this comment.
Could we add a processor unit test for this case please?
Contributor
Author
There was a problem hiding this comment.
Yep, just added it in the commit acf376b
ancalita
approved these changes
Jan 19, 2024
Member
ancalita
left a comment
ancalita
left a comment
There was a problem hiding this comment.
Nicely done 💯 Only the linting needs to be fixed.
ancalita
reviewed
Jan 19, 2024
| "text": "I like sunny days in berlin", | ||
| "intent": {"name": "chitchat", "confidence": 0.9}, | ||
| "entities": [], | ||
| "response_selector": { |
Member
There was a problem hiding this comment.
Not sure if this is a duplicate curly brace or meant to be a list of dicts instead?
Contributor
Author
There was a problem hiding this comment.
It was indeed a duplicate curly brace, I missed it when I copied the response_selector dictionary from an example bot
This was referenced Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
FULL_RETRIEVAL_INTENT_NAME_KEYto the intent dictionary. This has downstream effects and fixes a bug in the Analytics pipeline that expects this keyStatus (please check what you already did):
black(please check Readme for instructions)