feat: move Badge to elements and expose it in public API #12796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Trancever! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
satya164
added a commit
that referenced
this pull request
Oct 22, 2025
**Motivation** Badge is currently not exposed via public API of the lib which makes it impossible to use it when building custom tab. **Test plan** Run example app and check that nothing is broken. This PR only moves the file and exposes component in elements package public API. I renamed component from Badge to TabBarIconBadge so it's clear what it is for, but if it's not desired, let me know and I will fix it. --------- Co-authored-by: Satyajit Sahoo <[email protected]>
satya164
added a commit
that referenced
this pull request
Nov 1, 2025
**Motivation** Badge is currently not exposed via public API of the lib which makes it impossible to use it when building custom tab. **Test plan** Run example app and check that nothing is broken. This PR only moves the file and exposes component in elements package public API. I renamed component from Badge to TabBarIconBadge so it's clear what it is for, but if it's not desired, let me know and I will fix it. --------- Co-authored-by: Satyajit Sahoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Badge is currently not exposed via public API of the lib which makes it impossible to use it when building custom tab.
Test plan
Run example app and check that nothing is broken. This PR only moves the file and exposes component in elements package public API.
I renamed component from Badge to TabBarIconBadge so it's clear what it is for, but if it's not desired, let me know and I will fix it.