From 86df222e80e813127592d9bc9e0bc463a3d11a0d Mon Sep 17 00:00:00 2001 From: Keisuke Mizuya Date: Mon, 21 Feb 2022 17:19:55 +0900 Subject: [PATCH 1/2] remove hiredis ssl not implemented exception https://github.com/redis/redis-rb/issues/828 --- lib/redis/connection/hiredis.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/redis/connection/hiredis.rb b/lib/redis/connection/hiredis.rb index 2e0a47222..1dbb6a3f1 100644 --- a/lib/redis/connection/hiredis.rb +++ b/lib/redis/connection/hiredis.rb @@ -15,8 +15,6 @@ def self.connect(config) if config[:scheme] == "unix" connection.connect_unix(config[:path], connect_timeout) - elsif config[:scheme] == "rediss" || config[:ssl] - raise NotImplementedError, "SSL not supported by hiredis driver" else connection.connect(config[:host], config[:port], connect_timeout) end From 1262e75c00ac4390b6ccdbc70f72dd7b16602398 Mon Sep 17 00:00:00 2001 From: ke-miz Date: Mon, 21 Feb 2022 17:48:52 +0900 Subject: [PATCH 2/2] remove hiredis test for ssl option --- test/ssl_test.rb | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/test/ssl_test.rb b/test/ssl_test.rb index 7f4688163..743a83a94 100644 --- a/test/ssl_test.rb +++ b/test/ssl_test.rb @@ -46,17 +46,6 @@ def test_ssl_blocking end end - driver(:hiredis, :synchrony) do - def test_ssl_not_implemented_exception - assert_raises(NotImplementedError) do - RedisMock.start({ ping: proc { "+PONG" } }, ssl_server_opts("trusted")) do |port| - redis = Redis.new(port: port, ssl: true, ssl_params: { ca_file: ssl_ca_file }) - redis.ping - end - end - end - end - private def ssl_server_opts(prefix)