Skip to content

fix(ui): use route-prefix in api requests#694

Merged
JosephKav merged 1 commit intomasterfrom
fix/ui/api-req-route-prefix
Dec 7, 2025
Merged

fix(ui): use route-prefix in api requests#694
JosephKav merged 1 commit intomasterfrom
fix/ui/api-req-route-prefix

Conversation

@JosephKav
Copy link
Copy Markdown
Collaborator

Was always using /api/v1 as the API url, ignoring any route-prefix the app may have.
Now we add getBasename() to that url.

@JosephKav JosephKav added the bug Something isn't working label Dec 7, 2025
@JosephKav JosephKav marked this pull request as ready for review December 7, 2025 23:49
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (cf82aa0) to head (ea0f4b0).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         132      132           
  Lines        8890     8890           
=======================================
  Hits         8785     8785           
  Misses         80       80           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JosephKav JosephKav merged commit 4a3669a into master Dec 7, 2025
7 checks passed
@JosephKav JosephKav deleted the fix/ui/api-req-route-prefix branch December 7, 2025 23:55
This was referenced Dec 7, 2025
@JosephKav JosephKav added the javascript Pull requests that update Javascript code label Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant