Skip to content

fix(ui): always convert notify fields to strings#712

Merged
JosephKav merged 1 commit intomasterfrom
708-bug-when-using-a-generic-webhook-and-url_fields-query-vars
Dec 11, 2025
Merged

fix(ui): always convert notify fields to strings#712
JosephKav merged 1 commit intomasterfrom
708-bug-when-using-a-generic-webhook-and-url_fields-query-vars

Conversation

@JosephKav
Copy link
Copy Markdown
Collaborator

  • convert to a valid notify api format rather than leaving in the form format
  • consider both main and type defaults on webhook/notify payload creation (default array removals)

- convert to a valid notify api format rather than leaving in the form format
- consider both main and type defaults on webhook/notify payload creation (default array removals)
@JosephKav JosephKav added the bug Something isn't working label Dec 11, 2025
@JosephKav JosephKav linked an issue Dec 11, 2025 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (5b6ff38) to head (7b1b638).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #712   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         132      132           
  Lines        8891     8891           
=======================================
  Hits         8786     8786           
  Misses         80       80           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JosephKav JosephKav merged commit 383c379 into master Dec 11, 2025
7 checks passed
@JosephKav JosephKav deleted the 708-bug-when-using-a-generic-webhook-and-url_fields-query-vars branch December 11, 2025 14:53
This was referenced Dec 11, 2025
@JosephKav JosephKav added the javascript Pull requests that update Javascript code label Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: when using a generic webhook and url_fields (Query vars)

1 participant