Skip to content

fix(ui): prevent duplicate query params in refresh URL#771

Merged
JosephKav merged 3 commits intomasterfrom
fix/ui/refresh-duplicate-query-params
Dec 24, 2025
Merged

fix(ui): prevent duplicate query params in refresh URL#771
JosephKav merged 3 commits intomasterfrom
fix/ui/refresh-duplicate-query-params

Conversation

@JosephKav
Copy link
Copy Markdown
Collaborator

@JosephKav JosephKav commented Dec 24, 2025

Was appending the ? for query params twice
e.g. /api/v1/refresh?service_id=ID?overrides=Y

Now /api/v1/refresh?service_id=ID&overrides=Y

(From the change from path params to query params in #769)

@JosephKav JosephKav added bug Something isn't working javascript Pull requests that update Javascript code labels Dec 24, 2025
@JosephKav JosephKav marked this pull request as ready for review December 24, 2025 14:53
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (d57c0ea) to head (99ad0af).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         136      136           
  Lines        9105     9105           
=======================================
  Hits         9014     9014           
  Misses         69       69           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JosephKav JosephKav merged commit 6d7d7c3 into master Dec 24, 2025
7 of 8 checks passed
@JosephKav JosephKav deleted the fix/ui/refresh-duplicate-query-params branch December 24, 2025 15:29
@Argus-Bot Argus-Bot mentioned this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant