-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(composer): Make --minimal-config flag configurable
#39824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(composer): Make --minimal-config flag configurable
#39824
Conversation
|
Thank you for opening this PR. I was just researching why renovate stopped creating the desired lock file maintenance and found this exact flag being used in the log. For completeness, composer even notifies about this being a mistake in this command. However, I do not think it should be made configurable in the way you suggest. It is great to use with the actual update commands, but it should never be used with the lock file maintance action. |
|
@bobvandevijver my initial thought was to just undo the flag introduction. But given than it was already in the codebase, I thought of easy way of undoing it without removing it completely for folks who think its useful. This PR could be a first step, after which it can be reviewed and polished out. |
RahulGautamSingh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the type to RenovateConfig instead .. it should get passed down from there where needed.
Can you please be more specific? Thank you. |
Co-authored-by: RahulGautamSingh <[email protected]>
Find the |
Changes
Currently
--minimal-changesflag is being applied tocomposercommands. It was recently introduced in PR #34218. This has caused following issue #39823. As a solution, newcomposerMinimalChangesconfiguration is introduced, which allows--minimal-changesto be optionally applied instead of being a default behavior.Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: