Merged
Conversation
Contributor
Author
Contributor
|
@wltsmrz can you add some documentation around the purpose of this build and for what cases it should be used. I would also like to understand better why |
Contributor
Author
|
I'm not sure where documentation should be added. I'll add a release note when this is merged As the entry point is |
Contributor
|
Can you add a 'build' paragraph to the README? This would fit nicely in there. |
Contributor
|
Agree on adding docs. Implementation-wise looking good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "core" browser build of ripple-lib which has a subset of features and smaller file size
Restrictions
Using an unavailable class (e.g. calling
remote#createTransaction) will throw an error such asError: Class is unavailable in this build: TransactionResults