Skip to content

Balance sheet#579

Merged
clark800 merged 7 commits intoXRPLF:developfrom
wltsmrz:balance-sheet
Oct 5, 2015
Merged

Balance sheet#579
clark800 merged 7 commits intoXRPLF:developfrom
wltsmrz:balance-sheet

Conversation

@wltsmrz
Copy link
Copy Markdown
Contributor

@wltsmrz wltsmrz commented Oct 3, 2015

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required and additionalProperties should be outside the properties object

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to just do {"$ref": "amount"} here.

@clark800
Copy link
Copy Markdown
Contributor

clark800 commented Oct 5, 2015

LGTM

clark800 added a commit that referenced this pull request Oct 5, 2015
@clark800 clark800 merged commit 29c37aa into XRPLF:develop Oct 5, 2015
@clark800
Copy link
Copy Markdown
Contributor

clark800 commented Oct 5, 2015

Oops, forgot squash, oh well

@wltsmrz
Copy link
Copy Markdown
Contributor Author

wltsmrz commented Oct 5, 2015

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants