Skip to content

Conversation

@rustatian
Copy link
Member

@rustatian rustatian commented Sep 18, 2025

Reason for This PR

  • stable release cycle

Description of Changes

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Chores
    • Upgraded Go to 1.25 and refreshed core dependencies for improved compatibility and security.
    • Updated RoadRunner core and plugins to latest patch/minor versions for stability and performance.
    • Adjusted project template to generate go.mod with Go 1.25 and newer library versions.
    • Ignored macOS .DS_Store files in version control.
  • Refactor
    • Made build-related command execution context-aware to support safer cancellations without changing user-facing behavior.

@rustatian rustatian requested a review from Copilot September 18, 2025 15:32
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 18, 2025

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

This PR updates command execution in the builder to use context-aware calls, fixes a method name typo, bumps Go to 1.25, updates dependencies and template defaults, adjusts RoadRunner/Velox plugin versions, and adds .DS_Store to .gitignore. No exported APIs change.

Changes

Cohort / File(s) Summary of Changes
Ignore rules
\.gitignore
Added .DS_Store to ignore list.
Builder exec context + typo fix
builder/builder.go
Imported context; replaced exec.Command with exec.CommandContext(context.Background(), ...) in build/mod commands; renamed goModDowloadCmdgoModDownloadCmd and updated its call site.
Go module template (2025)
builder/templates/templateV2025.go
Updated GoModTemplateV2025: go 1.24/toolchaingo 1.25; bumped cobra to v1.10.1, viper to v1.21.0.
Module/deps bump
go.mod
Go version 1.25; removed toolchain directive; upgraded cobra, viper, testify, gitlab client-go, x/mod, x/oauth2; refreshed indirect deps and added new indirects.
Velox/RoadRunner versions
velox.toml
Bumped RoadRunner core to v2025.1.3; incremented multiple plugin refs (e.g., temporal, otel, http, server, redis, kafka, etc.); no structural changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant CLI as CLI
  participant Builder as Builder
  participant OS as OS Shell
  participant GoTool as Go Toolchain

  CLI->>Builder: Build()
  rect rgba(230,245,255,0.6)
    note over Builder: Context-aware exec (new)
    Builder->>OS: exec.CommandContext(ctx, "go", "mod", "download")
    OS->>GoTool: go mod download
    GoTool-->>OS: exit code
    OS-->>Builder: result
  end

  rect rgba(230,245,255,0.6)
    Builder->>OS: exec.CommandContext(ctx, "go", "mod", "tidy")
    OS->>GoTool: go mod tidy
    GoTool-->>OS: exit code
    OS-->>Builder: result
  end

  rect rgba(230,245,255,0.6)
    Builder->>OS: exec.CommandContext(ctx, "go", "build", ...)
    OS->>GoTool: go build
    GoTool-->>OS: artifact/exit
    OS-->>Builder: result
  end

  Builder-->>CLI: Build result
  note over Builder,OS: Commands can be canceled via context
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

C-enhancement, R-stable

Suggested reviewers

  • wolfy-j

Poem

A nibble of Go, a hop to one-two-five,
I tidy my mods where the builds arrive.
Context in paw, I cancel with grace,
Plugins all bumped—what a swift race!
.DS_Store gone, my burrow stays clean,
Carrots compiled, in verdant sheen. 🥕🐇

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/v2025.1.3

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b9b49ff and 2d3a3f0.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • .gitignore (1 hunks)
  • builder/builder.go (5 hunks)
  • builder/templates/templateV2025.go (1 hunks)
  • go.mod (1 hunks)
  • velox.toml (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the RoadRunner ecosystem to version 2025.1.3 with Go 1.25 support. The changes prepare the project for compatibility with the latest RoadRunner releases and update all plugin dependencies to their newest versions.

  • Updates the main RoadRunner reference from v2025.1.2 to v2025.1.3
  • Upgrades Go version requirement from 1.24 to 1.25
  • Updates all plugin dependencies to their latest compatible versions

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

File Description
velox.toml Updates RoadRunner core version and all plugin versions to support v2025.1.3
go.mod Upgrades Go version to 1.25 and updates all Go dependencies
builder/templates/templateV2025.go Updates Go module template to use Go 1.25 and latest dependency versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

golang.org/x/sys v0.33.0 // indirect
golang.org/x/text v0.26.0 // indirect
golang.org/x/time v0.12.0 // indirect
go.yaml.in/yaml/v3 v3.0.4 // indirect
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are duplicate YAML dependencies with different versions (v3.0.4 and v3.0.1). This creates confusion and potential conflicts. Only one YAML v3 dependency should be present.

Suggested change
go.yaml.in/yaml/v3 v3.0.4 // indirect

Copilot uses AI. Check for mistakes.
golang.org/x/sys v0.36.0 // indirect
golang.org/x/text v0.29.0 // indirect
golang.org/x/time v0.13.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are duplicate YAML dependencies with different versions (v3.0.4 and v3.0.1). This creates confusion and potential conflicts. Only one YAML v3 dependency should be present.

Suggested change
gopkg.in/yaml.v3 v3.0.1 // indirect

Copilot uses AI. Check for mistakes.
Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian self-assigned this Sep 18, 2025
@rustatian rustatian changed the base branch from master to stable September 18, 2025 15:38
@rustatian rustatian merged commit a6a478d into stable Sep 18, 2025
1 of 2 checks passed
@rustatian rustatian deleted the release/v2025.1.3 branch September 18, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 BUG]: the velox build is broken after updating the go version in the dependent plugins

2 participants