-
-
Notifications
You must be signed in to change notification settings - Fork 5
release: v2025.1.3 #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v2025.1.3 #266
Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
|
Caution Review failedThe pull request is closed. Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis PR updates command execution in the builder to use context-aware calls, fixes a method name typo, bumps Go to 1.25, updates dependencies and template defaults, adjusts RoadRunner/Velox plugin versions, and adds .DS_Store to .gitignore. No exported APIs change. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant CLI as CLI
participant Builder as Builder
participant OS as OS Shell
participant GoTool as Go Toolchain
CLI->>Builder: Build()
rect rgba(230,245,255,0.6)
note over Builder: Context-aware exec (new)
Builder->>OS: exec.CommandContext(ctx, "go", "mod", "download")
OS->>GoTool: go mod download
GoTool-->>OS: exit code
OS-->>Builder: result
end
rect rgba(230,245,255,0.6)
Builder->>OS: exec.CommandContext(ctx, "go", "mod", "tidy")
OS->>GoTool: go mod tidy
GoTool-->>OS: exit code
OS-->>Builder: result
end
rect rgba(230,245,255,0.6)
Builder->>OS: exec.CommandContext(ctx, "go", "build", ...)
OS->>GoTool: go build
GoTool-->>OS: artifact/exit
OS-->>Builder: result
end
Builder-->>CLI: Build result
note over Builder,OS: Commands can be canceled via context
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the RoadRunner ecosystem to version 2025.1.3 with Go 1.25 support. The changes prepare the project for compatibility with the latest RoadRunner releases and update all plugin dependencies to their newest versions.
- Updates the main RoadRunner reference from v2025.1.2 to v2025.1.3
- Upgrades Go version requirement from 1.24 to 1.25
- Updates all plugin dependencies to their latest compatible versions
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| velox.toml | Updates RoadRunner core version and all plugin versions to support v2025.1.3 |
| go.mod | Upgrades Go version to 1.25 and updates all Go dependencies |
| builder/templates/templateV2025.go | Updates Go module template to use Go 1.25 and latest dependency versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| golang.org/x/sys v0.33.0 // indirect | ||
| golang.org/x/text v0.26.0 // indirect | ||
| golang.org/x/time v0.12.0 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect |
Copilot
AI
Sep 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are duplicate YAML dependencies with different versions (v3.0.4 and v3.0.1). This creates confusion and potential conflicts. Only one YAML v3 dependency should be present.
| go.yaml.in/yaml/v3 v3.0.4 // indirect |
| golang.org/x/sys v0.36.0 // indirect | ||
| golang.org/x/text v0.29.0 // indirect | ||
| golang.org/x/time v0.13.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect |
Copilot
AI
Sep 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are duplicate YAML dependencies with different versions (v3.0.4 and v3.0.1). This creates confusion and potential conflicts. Only one YAML v3 dependency should be present.
| gopkg.in/yaml.v3 v3.0.1 // indirect |
Signed-off-by: Valery Piashchynski <[email protected]>
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.Summary by CodeRabbit