Kh add partner specific info fixes (#5270)

* Database migration

* feat: add frontend form field and controller changes

* update frontend view for partner

* update label copy

* add test + run linter

* Inline tiny partial into main show

* Fix model annotation and whitespace

* Add info for the bank to see on the partner show page

Fix layout on the partner's dashboard

* Handle empty-string bank-partner-info, and improve header

---------

Co-authored-by: Kate Higa <[email protected]>

Author: awwaiid

app/assets/stylesheets/resources/partners.scss

@@ -49,6 +49,10 @@ div#partner-notes {
   padding: 0px 20px;
 }
 
+div#info-for-partner {
+  padding: 0px 20px;
+}
+
 div#approve-application-button {
   position: fixed;
 

app/controllers/partners_controller.rb

@@ -182,7 +182,7 @@ def validate_user_role
 
   def partner_params
     params.require(:partner).permit(:name, :email, :send_reminders, :quota,
-      :notes, :partner_group_id, :default_storage_location_id, documents: [])
+      :notes, :partner_group_id, :default_storage_location_id, :info_for_partner, documents: [])
   end
 
   helper_method \

app/models/partner.rb

@@ -4,6 +4,7 @@
 #
 #  id                          :integer          not null, primary key
 #  email                       :string
+#  info_for_partner            :text
 #  name                        :string
 #  notes                       :text
 #  quota                       :integer

app/views/partners/_form.html.erb

@@ -46,6 +46,10 @@
               <%= f.input :notes, label: "Notes", wrapper: :input_group do %>
                 <%= f.input_field :notes, class: "form-control" %>
               <% end %>
+              <%= f.input :info_for_partner, label: "Partner specific information (500 characters)", wrapper: :input_group do %>
+                <%= f.input_field :info_for_partner, class: "form-control", "aria-describedby": "info-for-partner-note", maxlength: 500 %>
+              <% end %>
+                <p class="form-text" id="info-for-partner-note">Note: The partner can see, but cannot change this information.</p>
               <%= f.input :documents, label: "Documents", wrapper: :input_group do %>
                 <% if @partner.documents.present? %>
                   <ul class="list-unstyled w-100">

app/views/partners/dashboards/show.html.erb

@@ -6,6 +6,16 @@
 </header>
 
 <main>
+  <% if @partner.info_for_partner.present? %>
+    <section class="container mx-auto my-5">
+      <h2 class="font-weight-bold">Information from <%= @parent_org.name %></h2>
+
+      <div class="rounded-3 w-100 shadow-lg p-2 bg-white">
+        <%= @partner.info_for_partner %>
+      </div>
+    </section>
+  <% end %>
+
   <%= render partial: '/partners/requests/request_options_card' if @partner.approved? %>
 
   <section class="container mx-auto my-5">

app/views/partners/show.html.erb

@@ -186,6 +186,23 @@
           </div>
         </section>
 
+        <section class="card card-info card-outline">
+          <div class="card-header">
+            <h2 class="card-title fs-3">Partner Specific Information</h2>
+          </div>
+          <div class="card-body p-2">
+            <div class="row">
+              <div class="col-xs-12 col-sm-12" id="info-for-partner">
+                <% if @partner.info_for_partner %>
+                  <p><%= simple_format(@partner.info_for_partner) %></p>
+                <% else %>
+                  <p> None provided </p>
+                <% end %>
+              </div>
+            </div>
+          </div>
+        </section>
+
         <section class="card card-info card-outline" id='partner-information'>
           <div class="card-header">
             <div class="clearfix">

db/migrate/20250409014424_add_info_for_partner_to_partner.rb

@@ -0,0 +1,5 @@
+class AddInfoForPartnerToPartner < ActiveRecord::Migration[8.0]
+  def change
+    add_column :partners, :info_for_partner, :text
+  end
+end

db/schema.rb

@@ -631,6 +631,7 @@
     t.integer "quota"
     t.bigint "partner_group_id"
     t.bigint "default_storage_location_id"
+    t.text "info_for_partner"
     t.index ["default_storage_location_id"], name: "index_partners_on_default_storage_location_id"
     t.index ["organization_id"], name: "index_partners_on_organization_id"
     t.index ["partner_group_id"], name: "index_partners_on_partner_group_id"

spec/factories/kits.rb

@@ -11,15 +11,6 @@
 #  updated_at          :datetime         not null
 #  organization_id     :integer          not null
 #
-#  id                  :bigint           not null, primary key
-#  active              :boolean          default(TRUE)
-#  name                :string           not null
-#  value_in_cents      :integer          default(0)
-#  visible_to_partners :boolean          default(TRUE), not null
-#  created_at          :datetime         not null
-#  updated_at          :datetime         not null
-#  organization_id     :integer          not null
-
 FactoryBot.define do
   factory :kit do
     sequence(:name) { |n| "#{n} - Dont test this" }

spec/factories/partners.rb

@@ -4,6 +4,7 @@
 #
 #  id                          :integer          not null, primary key
 #  email                       :string
+#  info_for_partner            :text
 #  name                        :string
 #  notes                       :text
 #  quota                       :integer