4672: Align numeric values to the right #5316
Conversation
|
@napster235 I changed "resolves" to "partial" above, as there may be (i think are) more alignment issues than just the numeric columns. ("Resolves" would cause the workflow to close the issue when this is merged.) |
|
Sure, no prob @cielf. I searched in other places for alignment issues and I couldn't find any. Maybe I missed them. But all looked ok to me. If you know a specific place do let me know. Thanks |
|
Changing it back to resolves -- I think this solves the "does the header align with the content" problem. We definitely have some inconsistencies between different pages, but those can be a different issue. |
There was a problem hiding this comment.
@napster235 Thank you for this!
-- One minor thing around barcodes to adjust.
There are other alignment-related issues we have, but I'm going to take those to a different issue -- this will take care of all the alignment between header and content issues.
| <td><%= barcode_item_row.quantity %></td> | ||
| <td><%= barcode_item_row.value %></td> | ||
| <td class="numeric"><%= barcode_item_row.quantity %></td> | ||
| <td class="numeric"><%= barcode_item_row.value %></td> |
There was a problem hiding this comment.
Hmmm.. Barcodes are a weird case. The barcodes are strings made of digits, but they aren't amounts.
They should be left-justified. For clarity, The quantities should be right justified, but the actual barcodes left-justified.
| <tr> | ||
| <th>Item Type</th> | ||
| <th class="text-right">Quantity in the Box</th> | ||
| <th class="text-right">Barcode</th> |
There was a problem hiding this comment.
and hence the header for barcode should be left-justified as well.
|
@cielf I made the changes. This is how the barcode table looks now. |
|
@napster235: Your PR |
2 participants
Resolves #4672
Description
Type of change
How Has This Been Tested?
Manually tested
Screenshots
Barcode Items
Donations
Inventory Transfers
Manufacturers