5308 Audit CSV Export #5322
5308 Audit CSV Export #5322
Conversation
john-huang-121
force-pushed
the
5308-export-audit-csv
branch
from
e683f90 to
505d25c
Compare
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
Thanks for the first draft!
john-huang-121
force-pushed
the
5308-export-audit-csv
branch
from
61f6a07 to
ccff0fa
Compare
|
Can we re-run that spec-system test? Seems flakey. |
|
spec/models/audit_spec.rb
Outdated
| expect(csv_data).to eq( | ||
| <<~CSV | ||
| Audit Date,Audit Status,Storage Location Name,#{audit.line_items.first.name},#{audit_2.line_items.first.name} | ||
| #{audit.updated_at.strftime("%B %d %Y")},#{audit.status},#{sl.name},#{audit.line_items.first.quantity},0 |
There was a problem hiding this comment.
Please replace these with actual names, quantities, status etc. You can use freeze_time to hardcode the times as well. This will make the test less flaky and ensure we are asserting what we think we're asserting.
There was a problem hiding this comment.
updated to a more hardcoded spec.
|
Hello @awwaiid, do you have time to review my PR? |
|
Hey, @awwaiid, @janeewheatley and I completed functional testing and we're seeing that the export Audit button and the example export looks good (attached) |
|
Pending ticket: "Please wait" must not persist on the export button label after the export is complete |
|
@ruestitch Thank you for testing! |
|
@john-huang-121: Your PR |
3 participants
Resolves #5308
Description
This feature adds the 'Export Audit' button to the Audits page. Similar to the Storage Location page except includes the audit date and status in the report.
Type of change
How Has This Been Tested?
I first had to create a new Audit before exporting the CSV file.
Once that's done, I clicked the button and was able to get the csv of the audit.
Screenshots
New Export Button
