chore: PHP 8.4 preparation by signor-pedro · Pull Request #2297 · ruflin/Elastica

signor-pedro · 2026-03-20T09:56:03Z

Description: Prepare BrandEmbassy/Elastica for PHP 8.4 compatibility
Possible impact: CI pipeline, PHP version compatibility

Summary

Test commit to verify which CI pipelines are triggered on PRs
Will be updated with actual PHP 8.2/8.3/8.4 CI matrix changes

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

Documentation
- Updated README to reflect PHP 8.4 preparation.
Chores
- Added automated security scanning workflow.
- Updated package metadata.

DE-57584: Configure GHA for Black Duck scanning.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

signor-pedro · 2026-03-20T09:56:13Z

Opened against wrong repo by mistake, closing.

coderabbitai · 2026-03-20T09:56:22Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7fd5b7b7-f9cb-4fa5-94d3-74f55a80b738

📥 Commits

Reviewing files that changed from the base of the PR and between bc9eeaf and 08b0f78.

📒 Files selected for processing (3)

.github/workflows/blackduck.yaml
README.md
composer.json

📝 Walkthrough

Walkthrough

This PR adds a BlackDuck security scanning workflow triggered monthly and on pushes to the master branch, updates the README title to reference PHP 8.4 preparation, and changes the Composer package identifier from ruflin/elastica to brandembassy/elastica.

Changes

Cohort / File(s)	Summary
CI/CD Configuration `.github/workflows/blackduck.yaml`	New GitHub Actions workflow configured to run Synopsys Detect scans on master branch pushes and monthly schedule, with BlackDuck integration and environment variables for scanning configuration.
Documentation `README.md`	Updated heading title to append "- PHP 8.4 preparation" with corresponding underline adjustment.
Package Configuration `composer.json`	Changed package name field from `ruflin/elastica` to `brandembassy/elastica`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A scan for security, BlackDuck on the case,
PHP 8.4 preparation takes its place,
BrandEmbassy elastica now claims its name,
With monthly checks guarding the codebase flame! ✨

Important

Merge conflicts detected (Beta)

Resolve merge conflict in branch php-84-preparation

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use your project's `phpmd` ruleset to improve the quality of PHP code reviews.

You can customize the ruleset in your CodeRabbit configuration, or provide a path to a custom ruleset file.

Copilot

Pull request overview

This PR appears to be a “trigger test”/prep PR, but it currently introduces repo/package identity changes (Composer package name + README title) and adds a new scheduled Black Duck scanning workflow.

Changes:

Renames the Composer package from ruflin/elastica to brandembassy/elastica.
Updates the README title to mention “PHP 8.4 preparation”.
Adds a GitHub Actions workflow to run Synopsys Black Duck scans on master pushes and on a monthly schedule.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
composer.json	Changes the published Composer package name (potentially breaking for consumers).
README.md	Updates the project title; other content still references `ruflin/Elastica`.
.github/workflows/blackduck.yaml	Introduces a new Black Duck scan workflow (push/scheduled triggers).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-20T09:58:10Z

composer.json

@@ -1,5 +1,5 @@
 {
-    "name": "ruflin/elastica",
+    "name": "brandembassy/elastica",


Changing the Composer package name from "ruflin/elastica" to "brandembassy/elastica" is a breaking change for downstream consumers (install/upgrade paths, Packagist metadata, and any references in docs/CI). If this repo is intended to remain a fork, consider keeping the original package name (or clearly documenting the new install name and ensuring the old name is not referenced elsewhere).

Suggested change

"name": "brandembassy/elastica",

"name": "ruflin/elastica",

Copilot · 2026-03-20T09:58:11Z

README.md

+Elastica: elasticsearch PHP Client - PHP 8.4 preparation
+=========================================================

 [![Latest Stable Version](https://poser.pugx.org/ruflin/Elastica/v/stable.png)](https://packagist.org/packages/ruflin/elastica)
 [![Build Status](https://secure.travis-ci.org/ruflin/Elastica.png?branch=master)](http://travis-ci.org/ruflin/Elastica)


The README title now claims "PHP 8.4 preparation", but the document (badges/links and the compatibility table) still points to ruflin/Elastica and indicates PHP ^7.0 support. This is misleading; either update the related links/compatibility info to match the new package/repo direction or remove the PHP 8.4 note until the actual compatibility work lands.

Copilot · 2026-03-20T09:58:11Z

.github/workflows/blackduck.yaml

+on:
+  push:
+    branches:
+      - master
+  schedule:
+    # Execute at 00:00 on 1st day of every month
+    - cron: '0 0 1 * *'


The PR description mentions verifying which CI pipelines are triggered on PRs, but this workflow only runs on push to master and on a schedule. If you need PR validation/trigger testing, add a pull_request and/or workflow_dispatch trigger (keeping secrets usage in mind for PR runs).

Copilot · 2026-03-20T09:58:11Z

.github/workflows/blackduck.yaml

+  blackduck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2


actions/checkout@v2 is quite old and may hit GitHub Actions runtime deprecations (Node runtime updates) sooner than newer major versions. Consider upgrading to actions/checkout@v4 to reduce the chance of workflow breakage and to stay aligned with current GitHub-recommended versions.

Suggested change

- uses: actions/checkout@v2

- uses: actions/checkout@v4

michalbrauner and others added 5 commits December 5, 2017 08:07

Update composer.json

cd0bec0

Merge remote-tracking branch 'upstream/master'

a43676a

DE-57584: Configure GHA for Black Duck scanning.

c9aee74

Merge pull request #12 from BrandEmbassy/DE-57584-black-duck

9a80b4e

DE-57584: Configure GHA for Black Duck scanning.

chore: test commit to verify CI pipeline triggers

08b0f78

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings March 20, 2026 09:56

signor-pedro closed this Mar 20, 2026

Copilot started reviewing on behalf of signor-pedro March 20, 2026 09:56 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

signor-pedro deleted the php-84-preparation branch March 20, 2026 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: PHP 8.4 preparation#2297

chore: PHP 8.4 preparation#2297
signor-pedro wants to merge 5 commits intoruflin:9.xfrom
BrandEmbassy:php-84-preparation

signor-pedro commented Mar 20, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

signor-pedro commented Mar 20, 2026

Uh oh!

coderabbitai bot commented Mar 20, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Merge conflicts detected (Beta)

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

signor-pedro commented Mar 20, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Release Notes

Uh oh!

signor-pedro commented Mar 20, 2026

Uh oh!

coderabbitai bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Merge conflicts detected (Beta)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

signor-pedro commented Mar 20, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 20, 2026 •

edited

Loading