add issue link comments and bless

Author: danieljofficial

tests/ui/statics/static-cannot-use-local-variable.fixed

@@ -1,3 +1,7 @@
+//! Regression test for https://github.com/rust-lang/rust/issues/3521
+//!
+//! Tests that using a local variable in a `static` item inside a
+//! function body produces error E0435.
 //@ run-rustfix
 fn main() {
     let foo = 100;

tests/ui/statics/static-cannot-use-local-variable.rs

@@ -1,3 +1,7 @@
+//! Regression test for https://github.com/rust-lang/rust/issues/3521
+//!
+//! Tests that using a local variable in a `static` item inside a
+//! function body produces error E0435.
 //@ run-rustfix
 fn main() {
     let foo = 100;

tests/ui/statics/static-cannot-use-local-variable.stderr

@@ -1,5 +1,5 @@
 error[E0435]: attempt to use a non-constant value in a constant
-  --> $DIR/issue-3521-2.rs:5:23
+  --> $DIR/static-cannot-use-local-variable.rs:9:23
    |
 LL |     static y: isize = foo + 1;
    |                       ^^^ non-constant value

tests/ui/statics/static-in-fn-cannot-use-param.fixed

@@ -1,6 +1,12 @@
+//! Regression test for https://github.com/rust-lang/rust/issues/3668
+//!
+//! Tests that using a function parameter in a `static` item
+//! inside a function body produces error E0435 instead of
+//! crashing the compiler (ICE).
+
 //@ run-rustfix
 #![allow(unused_variables, dead_code)]
-fn f(x:isize) {
+fn f(x: isize) {
     let child: isize = x + 1;
     //~^ ERROR attempt to use a non-constant value in a constant
 }

tests/ui/statics/static-in-fn-cannot-use-param.rs

@@ -1,6 +1,12 @@
+//! Regression test for https://github.com/rust-lang/rust/issues/3668
+//!
+//! Tests that using a function parameter in a `static` item
+//! inside a function body produces error E0435 instead of
+//! crashing the compiler (ICE).
+
 //@ run-rustfix
 #![allow(unused_variables, dead_code)]
-fn f(x:isize) {
+fn f(x: isize) {
     static child: isize = x + 1;
     //~^ ERROR attempt to use a non-constant value in a constant
 }

tests/ui/statics/static-in-fn-cannot-use-param.stderr

@@ -1,5 +1,5 @@
 error[E0435]: attempt to use a non-constant value in a constant
-  --> $DIR/issue-3668-2.rs:4:27
+  --> $DIR/static-in-fn-cannot-use-param.rs:10:27
    |
 LL |     static child: isize = x + 1;
    |                           ^ non-constant value

tests/ui/statics/static-in-method-cannot-use-self.rs

@@ -1,14 +1,20 @@
-struct P { child: Option<Box<P>> }
+//! Regression test for https://github.com/rust-lang/rust/issues/3668
+//!
+//! Tests that using `self` in a `static` item inside a trait impl
+//! method produces error E0435 instead of crashing the compiler.
+struct P {
+    child: Option<Box<P>>,
+}
 trait PTrait {
-   fn getChildOption(&self) -> Option<Box<P>>;
+    fn getChildOption(&self) -> Option<Box<P>>;
 }
 
 impl PTrait for P {
-   fn getChildOption(&self) -> Option<Box<P>> {
-       static childVal: Box<P> = self.child.get();
-       //~^ ERROR attempt to use a non-constant value in a constant
-       panic!();
-   }
+    fn getChildOption(&self) -> Option<Box<P>> {
+        static childVal: Box<P> = self.child.get();
+        //~^ ERROR attempt to use a non-constant value in a constant
+        panic!();
+    }
 }
 
 fn main() {}

tests/ui/statics/static-in-method-cannot-use-self.stderr

@@ -1,13 +1,13 @@
 error[E0435]: attempt to use a non-constant value in a constant
-  --> $DIR/issue-3668.rs:8:34
+  --> $DIR/static-in-method-cannot-use-self.rs:14:35
    |
-LL |        static childVal: Box<P> = self.child.get();
-   |                                  ^^^^ non-constant value
+LL |         static childVal: Box<P> = self.child.get();
+   |                                   ^^^^ non-constant value
    |
 help: consider using `let` instead of `static`
    |
-LL -        static childVal: Box<P> = self.child.get();
-LL +        let childVal: Box<P> = self.child.get();
+LL -         static childVal: Box<P> = self.child.get();
+LL +         let childVal: Box<P> = self.child.get();
    |
 
 error: aborting due to 1 previous error

tests/ui/statics/static-lazy-init-with-arena-set.rs

@@ -1,29 +1,34 @@
+//! Regression test for https://github.com/rust-lang/rust/issues/39367
+//!
+//! Tests that lazy static initialization using `Once` and `transmute`
+//! works correctly with a struct that has a default type parameter.
 //@ run-pass
 
 use std::ops::Deref;
 
-struct ArenaSet<U: Deref, V=<U as Deref>::Target>(U, &'static V)
-    where V: 'static + ?Sized;
+struct ArenaSet<U: Deref, V = <U as Deref>::Target>(U, &'static V)
+where
+    V: 'static + ?Sized;
 
-static Z: [u8; 4] = [1,2,3,4];
+static Z: [u8; 4] = [1, 2, 3, 4];
 
 fn arena() -> &'static ArenaSet<Vec<u8>> {
     fn __static_ref_initialize() -> ArenaSet<Vec<u8>> {
         ArenaSet(vec![], &Z)
     }
     unsafe {
         use std::sync::Once;
-        fn require_sync<T: Sync>(_: &T) { }
+        fn require_sync<T: Sync>(_: &T) {}
         unsafe fn __stability() -> &'static ArenaSet<Vec<u8>> {
             use std::mem::transmute;
             static mut DATA: *const ArenaSet<Vec<u8>> = std::ptr::null_mut();
 
             static mut ONCE: Once = Once::new();
             ONCE.call_once(|| {
-            //~^ WARN creating a shared reference to mutable static [static_mut_refs]
-                DATA = transmute
-                    ::<Box<ArenaSet<Vec<u8>>>, *const ArenaSet<Vec<u8>>>
-                    (Box::new(__static_ref_initialize()));
+                //~^ WARN creating a shared reference to mutable static [static_mut_refs]
+                DATA = transmute::<Box<ArenaSet<Vec<u8>>>, *const ArenaSet<Vec<u8>>>(Box::new(
+                    __static_ref_initialize(),
+                ));
             });
 
             &*DATA

tests/ui/statics/static-lazy-init-with-arena-set.stderr

@@ -1,11 +1,11 @@
 warning: creating a shared reference to mutable static
-  --> $DIR/issue-39367.rs:22:13
+  --> $DIR/static-lazy-init-with-arena-set.rs:27:13
    |
 LL | /             ONCE.call_once(|| {
 LL | |
-LL | |                 DATA = transmute
-LL | |                     ::<Box<ArenaSet<Vec<u8>>>, *const ArenaSet<Vec<u8>>>
-LL | |                     (Box::new(__static_ref_initialize()));
+LL | |                 DATA = transmute::<Box<ArenaSet<Vec<u8>>>, *const ArenaSet<Vec<u8>>>(Box::new(
+LL | |                     __static_ref_initialize(),
+LL | |                 ));
 LL | |             });
    | |______________^ shared reference to mutable static
    |