Merge pull request #227 from sameerasw/develop

Develop - Critical bug fix with batteries notification

Author: sameerasw

app/build.gradle.kts

@@ -21,8 +21,8 @@ android {
         applicationId = "com.sameerasw.essentials"
         minSdk = 26
         targetSdk = 36
-        versionCode = 27
-        versionName = "11.3"
+        versionCode = 28
+        versionName = "11.4"
 
         testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
     }

app/src/main/java/com/sameerasw/essentials/services/BatteryNotificationService.kt

@@ -43,10 +43,16 @@ class BatteryNotificationService : Service() {
         settingsRepository = SettingsRepository(this)
         createNotificationChannel()
         settingsRepository.registerOnSharedPreferenceChangeListener(preferenceChangeListener)
+        
+        startForeground(NOTIF_ID, buildBaseNotification(getString(R.string.feat_batteries_title), ""))
+        
         updateNotification()
     }
 
     override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+             startForeground(NOTIF_ID, buildBaseNotification(getString(R.string.feat_batteries_title), ""))
+        }
         updateNotification()
         return START_STICKY
     }
@@ -77,26 +83,39 @@ class BatteryNotificationService : Service() {
 
     private fun updateNotification() {
         val batteryItems = fetchBatteryData()
-        if (batteryItems.isEmpty()) {
-            stopForeground(true)
-            stopSelf()
-            return
+        
+        val notification = if (batteryItems.isEmpty()) {
+            buildBaseNotification(
+                getString(R.string.feat_batteries_title),
+                getString(R.string.battery_notification_no_devices)
+            )
+        } else {
+            val bitmap = createCompositeBitmap(batteryItems)
+            NotificationCompat.Builder(this, CHANNEL_ID)
+                .setSmallIcon(R.drawable.rounded_battery_charging_60_24)
+                .setLargeIcon(bitmap)
+                .setStyle(NotificationCompat.BigPictureStyle()
+                    .bigPicture(bitmap)
+                    .bigLargeIcon(null as Bitmap?))
+                .setContentTitle(getString(R.string.feat_batteries_title))
+                .setPriority(NotificationCompat.PRIORITY_LOW)
+                .setOngoing(true)
+                .setSilent(true)
+                .build()
         }
 
-        val bitmap = createCompositeBitmap(batteryItems)
-        val notification = NotificationCompat.Builder(this, CHANNEL_ID)
+        startForeground(NOTIF_ID, notification)
+    }
+
+    private fun buildBaseNotification(title: String, content: String): Notification {
+        return NotificationCompat.Builder(this, CHANNEL_ID)
             .setSmallIcon(R.drawable.rounded_battery_charging_60_24)
-            .setLargeIcon(bitmap)
-            .setStyle(NotificationCompat.BigPictureStyle()
-                .bigPicture(bitmap)
-                .bigLargeIcon(null as Bitmap?))
-            .setContentTitle(getString(R.string.feat_batteries_title))
+            .setContentTitle(title)
+            .setContentText(content)
             .setPriority(NotificationCompat.PRIORITY_LOW)
             .setOngoing(true)
             .setSilent(true)
             .build()
-
-        startForeground(NOTIF_ID, notification)
     }
 
     private fun fetchBatteryData(): List<BatteryItemData> {

app/src/main/res/values/strings.xml

@@ -690,6 +690,7 @@
     <string name="update_channel_name">App Updates</string>
     <string name="update_channel_desc">Notifications for new app updates</string>
     <string name="notification_update_available">Update available</string>
+    <string name="battery_notification_no_devices">No devices connected</string>
 
     <string name="label_unknown">Unknown</string>
     <string name="network_type_5g">5G</string>