[Snyk] Security upgrade react-scripts from 1.1.5 to 4.0.0

[saurabharch]

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

• fixtures/concurrent/time-slicing/package.json
• fixtures/concurrent/time-slicing/yarn.lock

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

Vulnerabilities that will be fixed with an upgrade:

	Issue	Score
	Allocation of Resources Without Limits or Throttling SNYK-JS-QS-14724253	828

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Allocation of Resources Without Limits or Throttling

[gemini-code-assist]

Summary of Changes

Hello @saurabharch, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the security posture of the project by performing a critical upgrade of the react-scripts dependency. The update targets a high-severity vulnerability, ensuring more robust resource management and overall application stability. The changes are confined to the dependency manifest and lock files within a specific fixture, aiming to integrate the security fix with minimal impact.

Highlights

• Security Upgrade: Upgrades the react-scripts dependency from version 1.1.5 to 4.0.0 to address a high-severity vulnerability (SNYK-JS-QS-14724253) related to 'Allocation of Resources Without Limits or Throttling'.
• Dependency Updates: The package.json and yarn.lock files within the fixtures/concurrent/time-slicing/ directory have been updated to reflect the new react-scripts version.
• Zero-Install Consideration: Users leveraging Yarn's zero-install feature will need to manually run yarn to update their .yarn/cache directory after pulling these changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request, automatically generated by Snyk, upgrades react-scripts from ^1.1.4 to ^4.0.0 to fix a security vulnerability. While this is a necessary security update, it represents a major version jump (from v1 to v4) which introduces significant breaking changes to the build toolchain. I've left a comment on the package.json file highlighting the risk that this upgrade might break the time-slicing fixture, especially since it uses an old experimental version of React. I've also suggested an alternative, less disruptive approach using yarn resolutions to patch the vulnerable sub-dependency directly. Please review the comment and consider which approach is best for your project. Thorough testing will be required if you proceed with the react-scripts upgrade.

[gemini-code-assist]

Upgrading react-scripts from version 1 to 4 is a very large jump that introduces many breaking changes (e.g., webpack 3→4, Babel 6→7). Given this fixture uses an old experimental version of React (0.0.0-experimental-269dd6ec5), this upgrade has a high risk of breaking the build or functionality.

While this upgrade fixes the security vulnerability, a less disruptive approach would be to use yarn resolutions to specifically upgrade the vulnerable sub-dependency (qs).

I'd recommend either:

1. Thoroughly testing this fixture to ensure it still works as expected after this major upgrade.
2. Considering the alternative of using yarn resolutions to minimize the risk of breaking changes. You could add the following to this package.json:

   "resolutions": {
     "qs": "6.9.7"
   }

   Then run yarn install. This would upgrade qs to a safe version without changing react-scripts and its many other dependencies.