Fix weekday search #1274
Merged
Fix weekday search #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 28, 2025 08:38
In the german search test, "Die" whould return the nearest Tuesday to
the RELATIVE_BASE date of 2000-01-01. This date is 1999-12-28. The test
was set to expect 1999-01-28, 11 months earlier, and not a Tuesday.
December 1999 January 2000
Mo Tu We Th Fr Sa Su Mo Tu We Th Fr Sa Su
1 2 3 4 5 1 2
6 7 8 9 10 11 12 3 4 5 6 7 8 9
13 14 15 16 17 18 19 10 11 12 13 14 15 16
20 21 22 23 24 25 26 17 18 19 20 21 22 23
27 28 29 30 31 24 25 26 27 28 29 30
31
For a weekday search in `_correct_for_time_frame`, the parser object has no `_token_month` set. Leaving this unset after a weekday date is found allowed the month to be erroneously "corrected" by `_correct_for_month` which alters the month by default to the month of the `RELATIVE_BASE` date. We should instead set `_token_month` to that of the date found. Fixes scrapinghub#1266 Fixes scrapinghub#1249 Fixes scrapinghub#1243 Fixes scrapinghub#1202
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1274 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 234 234
Lines 2775 2776 +1
=======================================
+ Hits 2705 2706 +1
Misses 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gallaecio
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cases when searching only for a weekday where the parser had found the correct date but then erroneously "corrected" the month later.
Fixes #1266
Fixes #1249
Fixes #1243
Fixes #1202