This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The batch circuit now supports aggregation of chunk SNARKS (layer-2) that can belong to either of the following routes:
super circuit->compression circuit->compression circuitsp1->halo2-backend-> compression circuit`Prior, since only route 1 existed, the SNARK protocol was loaded as a constant. The fundamental change made in
snark-verifier(scroll-tech/snark-verifier#39) is to expose aaggregate_as_witnessmethod that loads the SNARK protocols as witness instead.In the batch circuit, we add the following constraints:
Type of change