Entity Keys: remove convertion of id string to integer#179
Merged
Conversation
…ity key id
The live Datastore treats the same way User.get("123") than User.get(123). Both return the entity
with the Key.id being "123". The convertion from string to integer has been removed inside gstore
and let to the consumer to implement if needed.
BREAKING CHANGE: The "keyType" Schema option has been removed as it is no longer needed. Also, as
gstore does not parse the id anymore, running your project against the Datastore emulator locally
might break as the emulator treats differently User.get(123) than User.get("123"). Auto-allocated
ids are integer and need to be provided as integer for the Emulator.
#168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live Datastore treats the same way User.get("123") than User.get(123). Both return the entity
with the Key.id being "123". The conversion from string to integer has been removed inside gstore
and let to the consumer to implement if needed.
BREAKING CHANGE: The "keyType" Schema option has been removed as it is no longer needed. Also, as gstore does not parse the id anymore, running your project against the local Datastore emulator might break as the emulator treats differently
User.get(123)thanUser.get("123"). Auto-allocated ids are integers and need to be provided as integers to the Emulator.Fixes #168