-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[VLM] Support PP for Qwen2.5-VL #13075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yuan-luo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for Pipeline Parallelism (PP) to the Qwen2.5-VL model. The changes enable efficient distribution of the model's layers across multiple devices, optimizing memory and computational resources for large-scale multimodal inference. It ensures that multimodal inputs are processed correctly at the initial stage, and model weights are loaded judiciously per pipeline stage, leading to improved scalability and performance. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
659e6c1 to
db18a33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for pipeline parallelism (PP) to the Qwen2.5-VL model. The changes correctly adapt the model's embedding, forward pass, and weight loading logic to work across multiple pipeline stages. For instance, embeddings are now computed only on the first rank, and the language model head is only initialized on the last rank. I've found one potential bug where auxiliary hidden states are computed but not passed to the logits processor, which could affect features like speculative decoding. Overall, the changes are well-structured for enabling pipeline parallelism.
Co-authored-by: Yuan Luo <[email protected]> Co-authored-by: Tianyu Guo <[email protected]>
db18a33 to
8b16cb0
Compare
|
nit: for code readability, you should better not use nested if statements. |
Motivation
This PR is to support PP for Qwen2.5-VL model.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist