-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[AMD] Apply AITER_MXFP4_MOE_SF=1 only to gfx950 in aiter build #13092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hubertlu-tw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces targeted modifications to the Dockerfile responsible for building Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request conditionally applies the AITER_MXFP4_MOE_SF=1 flag only for the gfx950 architecture during the aiter build in the ROCm Dockerfile. This is intended to fix a build error on MI300X. The changes correctly implement the conditional logic. My review includes suggestions to remove some dead code and to refactor the shell commands for better readability and maintainability.
Motivation
Apply AITER_MXFP4_MOE_SF=1 only to gfx950 in aiter build which resolves the current aiter build error on MI300X.
https://github.com/sgl-project/sglang/actions/runs/19269898923/job/55095147727#step:5:854
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
CC: @sogalin