Skip to content

Conversation

@jinyouzhi
Copy link
Contributor

@jinyouzhi jinyouzhi commented Nov 13, 2025

Motivation

Fix #13124

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@FlamingoPg FlamingoPg self-assigned this Nov 13, 2025
@jinyouzhi
Copy link
Contributor Author

Thanks for your review and triggering ci @FlamingoPg

@Fridge003
Copy link
Collaborator

Hi @jinyouzhi , can you split this PR into two. The first part is the change on sgl-kernel side (which can be merged now I think), and the second part is the change on srt side.

We need to bump sgl-kernel to make the srt change work

@jinyouzhi jinyouzhi changed the title Add FP32 dtype support for RoPE Add FP32 dtype support for RoPE - Part1 Nov 15, 2025
@jinyouzhi
Copy link
Contributor Author

Hi @jinyouzhi , can you split this PR into two. The first part is the change on sgl-kernel side (which can be merged now I think), and the second part is the change on srt side.您好,能否将此 PR 拆分为两部分?第一部分是 sgl-kernel 端的更改(我认为现在可以合并了),第二部分是 srt 端的更改。

We need to bump sgl-kernel to make the srt change work我们需要更新 sgl-kernel 内核才能使 srt 的更改生效。

Sure, great advice! I have followed it.

@Fridge003 Fridge003 merged commit 20e59f9 into sgl-project:main Nov 15, 2025
40 of 51 checks passed
@jinyouzhi jinyouzhi deleted the rope_fp32 branch November 18, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Rotary embedding kernel support float32 input dtype

3 participants