-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Piecewise] Use same global graph memory pool as the main cuda graph … #14044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…runner's memory pool
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
/tag-and-rerun-ci |
alisonshao
added a commit
that referenced
this pull request
Dec 2, 2025
…a graph" (#14044) This reverts commit 0f8e539. The original PR introduced two issues: 1. A bug in set_graph_pool_id where `if _graph_pool_id is not None` prevented the variable from ever being set (since it's initialized to None) 2. Sharing memory pool between piecewise and main cuda graph runners caused uninitialized memory issues on H100, resulting in TestQwen3NextPiecewiseCudaGraph failing with accuracy=0.0 This revert restores separate memory pools for piecewise cuda graph runner.
3 tasks
Fridge003
pushed a commit
that referenced
this pull request
Dec 2, 2025
harvenstar
pushed a commit
to harvenstar/sglang
that referenced
this pull request
Dec 4, 2025
sgl-project#14044) Co-authored-by: Stefan He <[email protected]> Co-authored-by: BBuf <[email protected]>
harvenstar
pushed a commit
to harvenstar/sglang
that referenced
this pull request
Dec 4, 2025
yingluosanqian
pushed a commit
to yingluosanqian/sglang
that referenced
this pull request
Dec 4, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 5, 2025
sgl-project#14044) Co-authored-by: Stefan He <[email protected]> Co-authored-by: BBuf <[email protected]>
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 5, 2025
yuchengz816-bot
pushed a commit
to yuchengz816-bot/sglang
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…runner's memory pool
Motivation
As titled
Accuracy Tests and Benchmarking and Profiling
When both decode cuda graph and piecewise cuda graph is enabled
When only piecewise cuda graph is enabled but decode cuda graph is disabled
Checklist