[3/N][Sparse With Hicache]: Init sparse coordinator#16086
[3/N][Sparse With Hicache]: Init sparse coordinator#16086xiezhq-hermann merged 6 commits intosgl-project:mainfrom
Conversation
Summary of ChangesHello @hzh0425, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a foundational framework for hierarchical sparse attention within SGLang, enabling the integration of various retrievable KV cache compression algorithms. The core Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new framework for hierarchical sparse attention, including a coordinator, algorithms, and backend adaptors. The changes are well-structured, separating concerns into distinct modules for better maintainability and extensibility. The configuration parsing is robust, handling JSON input for extra settings and providing sensible defaults. The integration with existing ServerArgs is also clear, adding new command-line arguments for enabling and configuring sparse attention.
|
@xiezhq-hermann could you take a review |
3e149cf to
bea7153
Compare
Co-authored-by: 晟海 <huangtingwei.htw@antgroup.com>
|
@hzh0425 This pr support Speculative Decoding ? |
|
Is there a dependency between this one and the last one (#15807)? |
It is independent and has no dependencies. |
Co-authored-by: 晟海 <huangtingwei.htw@antgroup.com> Co-authored-by: Zhiqiang Xie <xiezhq@stanford.edu>
Motivation
This PR introduces a flexible configuration framework for hierarchical sparse attention with retrievable KV cache compression algorithms (Quest, PQCache, SnapKV, etc.) in SGLang.
Upstream PR:#14619
Modifications
Coordinator Lifecycle Framework
Attention BackendAdaptor: https://github.com/sgl-project/sglang/pull/16086/files#diff-e0e2432b5521042dbac9e254d142233b2d8366b964ae83ce96f748730db53276R25
Accuracy Tests
#14741 (comment)
Benchmarking and Profiling
Checklist