refactor: improve code quality and type safety in search feature

- Move SearchableEpisode type to rss.ts for reuse across components
- Fix potential runtime error with optional episodeNumber field
- Import shared type in SearchDialog.tsx and search.json.ts

Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>

Author: Copilot

src/components/SearchDialog.tsx

@@ -1,12 +1,7 @@
 import type { JSX } from 'preact/jsx-runtime';
 import { useEffect, useState, useRef, useCallback } from 'preact/hooks';
 import { isSearchOpen } from './state';
-import type { Episode } from '../lib/rss';
-
-type SearchableEpisode = Pick<
-  Episode,
-  'id' | 'title' | 'description' | 'episodeNumber' | 'episodeSlug' | 'episodeThumbnail'
->;
+import type { SearchableEpisode } from '../lib/rss';
 
 export default function SearchDialog() {
   const [query, setQuery] = useState('');
@@ -40,7 +35,7 @@ export default function SearchDialog() {
         (episode) =>
           episode.title.toLowerCase().includes(lowerQuery) ||
           episode.description.toLowerCase().includes(lowerQuery) ||
-          episode.episodeNumber.toLowerCase().includes(lowerQuery)
+          (episode.episodeNumber?.toLowerCase().includes(lowerQuery) ?? false)
       )
       .slice(0, 8);
 

src/lib/rss.ts

@@ -31,6 +31,12 @@ export interface Episode {
   };
 }
 
+// Subset of Episode for search functionality
+export type SearchableEpisode = Pick<
+  Episode,
+  'id' | 'title' | 'description' | 'episodeNumber' | 'episodeSlug' | 'episodeThumbnail'
+>;
+
 let showInfoCache: Show | null = null;
 
 export async function getShowInfo() {

src/pages/api/episodes/search.json.ts

@@ -1,13 +1,13 @@
 import type { APIRoute } from 'astro';
-import { getAllEpisodes } from '../../../lib/rss';
+import { getAllEpisodes, type SearchableEpisode } from '../../../lib/rss';
 
 export const prerender = true;
 
 export const GET: APIRoute = async () => {
   const allEpisodes = await getAllEpisodes();
 
   // Return a simplified list of episodes optimized for search
-  const searchableEpisodes = allEpisodes.map((episode) => ({
+  const searchableEpisodes: SearchableEpisode[] = allEpisodes.map((episode) => ({
     id: episode.id,
     title: episode.title,
     description: episode.description,