fix: binary parser sometimes reads out of packet bounds when results …

[Parsonswy]

Fixes #2602.

Check the nullBitmaskByte before trying to readLengthCodedBuffer() when typeCast: false on binary results.

[sidorares]

thanks for fix PR and detailed report @Parsonswy ! Do you think it would be possible to include a unit test ( failing without lib/parsers/binary_parser.js changes and passing with )?

The main change looks good to me

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (2129818) to head (40f9224).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2601   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          71       71           
  Lines       15725    15727    +2     
  Branches     1339     1339           
=======================================
+ Hits        14204    14206    +2     
  Misses       1521     1521           

Flag	Coverage Δ
compression-0	90.32% <100.00%> (+<0.01%)	⬆️
compression-1	90.32% <100.00%> (+<0.01%)	⬆️
tls-0	89.85% <100.00%> (+<0.01%)	⬆️
tls-1	90.15% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Parsonswy]

@sidorares Certainly. Test added.

[wellwelwel]

LGTM 🚀