Fixed typing for caching_sha2_password where misspelt jonServerPublicKey is replaced by onServerPublicKey

[johanwestling]

Just a minor character missing as I assume it was supposed to be joinServerPublicKey instead of jonServerPublicKey.

[sidorares]

hi @johanwestling , thanks for noticing the typo. It should be onServerPublicKey, see how its used here:

node-mysql2/lib/auth_plugins/caching_sha2_password.js

Line 90 in 5c75802

pluginOptions.onServerPublicKey(data);

this is the callback which users can pass to be able to cache server public key and use it with initial connection to speed it up ( one less roundtrip ) or make more secure if tls is not used ( password is sent RSA encrypted using the key )

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (5c75802) to head (59b516b).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2699   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          71       71           
  Lines       15727    15727           
  Branches     1340     1339    -1     
=======================================
  Hits        14206    14206           
  Misses       1521     1521           

Flag	Coverage Δ
compression-0	90.32% <ø> (ø)
compression-1	90.32% <ø> (ø)
tls-0	89.85% <ø> (ø)
tls-1	90.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johanwestling]

hi @johanwestling , thanks for noticing the typo. In should be onServerPublicKey, see how its used here:

node-mysql2/lib/auth_plugins/caching_sha2_password.js

Line 90 in 5c75802

pluginOptions.onServerPublicKey(data);

this is the callback which users can pass to be able to cache server public key and use it with initial connection to speed it up ( one less roundtrip ) or make more secure if tls is not used ( password is sent RSA encrypted using the key )

Sorry for late response, was in transit. Now the joinServerPublicKey is replaced with the correct onServerPublicKey instead.