escape-case and no-hex-escape false positives – need to handle backslashes

[lydell]

package.json:

{
  "private": true,
  "eslintConfig": {
    "env": {
      "es6": true
    },
    "parserOptions": {
      "ecmaVersion": 2017,
      "sourceType": "module"
    },
    "plugins": [
      "unicorn"
    ],
    "rules": {
      "unicorn/escape-case": "error",
      "unicorn/no-hex-escape": "error"
    }
  },
  "scripts": {
    "test": "eslint test.js"
  },
  "devDependencies": {
    "eslint": "^3.15.0",
    "eslint-plugin-unicorn": "^2.0.1"
  }
}

test.js:

"\\ufeff"
"\\\\xa0"

Output:

$ npm test

> @ test /home/lydell/bugs/eslint-plugin-unicorn-bugs
> eslint test.js


/home/lydell/bugs/eslint-plugin-unicorn-bugs/test.js
  1:1  error  Use uppercase characters for the value of the escape sequence  unicorn/escape-case
  2:1  error  Use uppercase characters for the value of the escape sequence  unicorn/escape-case
  2:1  error  Use unicode escapes instead of hexadecimal escapes             unicorn/no-hex-escape

✖ 3 problems (3 errors, 0 warnings)

npm ERR! Test failed.  See above for more details.

Expected: No errors.

[sindresorhus]

I just encountered this myself. I had internal\\child_process which got reported and fixed as internal\\cHild_process...

[sindresorhus]

// @florianb In case you want to take a look at this ;)

[sindresorhus]

// @matijs

[florianb]

Unless somebody else is taking it, i will dig in at monday.. 😊

[matijs]

@florianb I'd like to fix no-hex-escape if that's alright with you :)

[florianb]

You are welcome! ;) Happy hacking and thanks! Matijs Brinkhuis <notifications@github.com> schrieb am 26.03.2017 12:46 nachm.: @florianb<https://github.com/florianb> I'd like to fix no-hex-escape if that's alright with you :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#85 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA8B04JKx10Vnsx9w5C0LS9Ea02GOKLMks5rpkH3gaJpZM4L4gNS>.