Tokenizer/PHP: fix ? tokenization after attribute#3446
Merged
gsherwood merged 1 commit intosquizlabs:masterfrom Oct 11, 2021
Merged
Conversation
In a select set of circumstance, when a `?` would follow an attribute with a nested array in it, the `?` would be tokenized as `T_INLINE_THEN`, not `T_NULLABLE`. Fixed now. Includes unit test via the `PSR12.Operators.OperatorSpacing` sniff. Note: Ternary `?` vs nullable (and ternary `:` vs colon) should really get a full set of unit tests, but I don't currently have the time to set that up. Fixes 3445
|
I tested it on my project, this is the correct fix for #3445 , Thank you ! |
Contributor
Author
|
Thanks for testing @mhlsf ! |
Member
|
Thanks for fixing this so quickly. Will sneak it into 3.6.1. |
Contributor
Author
|
Felt like an icky one... and thanks for including it in 3.6.1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a select set of circumstance, when a
?would follow an attribute with a nested array in it, the?would be tokenized asT_INLINE_THEN, notT_NULLABLE.Fixed now.
Includes unit test via the
PSR12.Operators.OperatorSpacingsniff.Note: Ternary
?vs nullable (and ternary:vs colon) should really get a full set of unit tests, but I don't currently have the time to set that up.Fixes #3445