fix(tui): pass fg prop to diff component for light mode support #5195
+526
−2,386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GENERATED WITH ASSISTANCE OF [OhMyOpenCode](https://github.com/code-yeongyu/oh-my-opencode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unreadable diff text on light mode themes by passing
fgprop to diff component.Problem
When using light mode themes, syntax-unhighlighted tokens in diff view render as white text (hardcoded default in opentui's CodeRenderable), making them invisible on light backgrounds.
Solution
Pass
fg={theme.text}to the<diff>component so unhighlighted text uses the theme's text color.Dependency
Requires sst/opentui#390 to be merged first (adds
fgprop support to DiffRenderable).