This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix: (Icon) search & table icon update#1011
Merged
Conversation
jaanus03
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
jaanus03
force-pushed
the
jaanusp/search-table-icon-update
branch
from
cd4c9a9 to
5af6058
Compare
jaanus03
changed the title
jaanus03
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
+ Coverage 81.37% 81.37% +<.01%
==========================================
Files 673 673
Lines 8697 8699 +2
Branches 1475 1475
==========================================
+ Hits 7077 7079 +2
Misses 1605 1605
Partials 15 15
Continue to review full report at Codecov.
|
codepretty
reviewed
Mar 4, 2019
packages/react/src/themes/teams/components/Icon/svg/icons/search.tsx
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Mar 4, 2019
packages/react/src/themes/teams/components/Icon/svg/icons/table.tsx
Outdated
Show resolved
Hide resolved
codepretty
approved these changes
Mar 4, 2019
Collaborator
codepretty
left a comment
codepretty
left a comment
There was a problem hiding this comment.
Looks good to me - just remember to add a changelog entry
jaanus03
force-pushed
the
jaanusp/search-table-icon-update
branch
from
5af6058 to
6c7b18a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates search & table icons:
Old search icons
New search icons
Old table icons
New table icons
