This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(components): align slotClassNames property for all components#1093
Merged
feat(components): align slotClassNames property for all components#1093
Conversation
4ced4d7 to
97b7e88
Compare
kuzhelov
reviewed
Mar 25, 2019
7b9da24 to
d135cfc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
+ Coverage 82.1% 82.11% +0.01%
==========================================
Files 717 717
Lines 8571 8584 +13
Branches 1233 1169 -64
==========================================
+ Hits 7037 7049 +12
Misses 1518 1518
- Partials 16 17 +1
Continue to review full report at Codecov.
|
kuzhelov
reviewed
Mar 27, 2019
82e8b8d to
c8f1dcd
Compare
kuzhelov
approved these changes
Mar 27, 2019
2fcd4f9 to
01b1965
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(components): align slotClassNames property for all components
Description
This PR:
MenuItemcomponents:MenuItem.slotClassNames.menuslotClassNamesproperty on composed components in order to be able to target subcomponents directly;e.g.: a
Menuitem can be targeted referencing:classNamedirectly:MenuItem.className// even before this PRMenu.slotClassNames.item// introduced in this PR