Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(components): align slotClassNames property for all components#1093

Merged
bmdalex merged 5 commits intomasterfrom
feat/components-align-slot-class-names
Mar 27, 2019
Merged

feat(components): align slotClassNames property for all components#1093
bmdalex merged 5 commits intomasterfrom
feat/components-align-slot-class-names

Conversation

@bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Mar 22, 2019

feat(components): align slotClassNames property for all components

Description

This PR:

  • introduces ability to select submenus from MenuItem components: MenuItem.slotClassNames.menu
  • aligns slotClassNames property on composed components in order to be able to target subcomponents directly;
    e.g.: a Menu item can be targeted referencing:
    • it's className directly: MenuItem.className // even before this PR
    • the item as a slot of the parent component: Menu.slotClassNames.item // introduced in this PR

@bmdalex bmdalex force-pushed the feat/components-align-slot-class-names branch 3 times, most recently from 4ced4d7 to 97b7e88 Compare March 25, 2019 14:27
@bmdalex bmdalex self-assigned this Mar 25, 2019
@kuzhelov kuzhelov added the needs author feedback Author's opinion is asked label Mar 25, 2019
@bmdalex bmdalex force-pushed the feat/components-align-slot-class-names branch 2 times, most recently from 7b9da24 to d135cfc Compare March 26, 2019 18:39
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #1093 into master will increase coverage by 0.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
+ Coverage    82.1%   82.11%   +0.01%     
==========================================
  Files         717      717              
  Lines        8571     8584      +13     
  Branches     1233     1169      -64     
==========================================
+ Hits         7037     7049      +12     
  Misses       1518     1518              
- Partials       16       17       +1
Impacted Files Coverage Δ
...ackages/react/src/components/Dropdown/Dropdown.tsx 54.14% <ø> (ø) ⬆️
packages/react/src/components/Menu/MenuItem.tsx 61.26% <ø> (ø) ⬆️
packages/react/src/components/Header/Header.tsx 100% <100%> (ø) ⬆️
packages/react/src/components/Tree/TreeItem.tsx 59.37% <100%> (+1.31%) ⬆️
packages/react/src/components/Menu/Menu.tsx 90.74% <100%> (+0.17%) ⬆️
...kages/react/src/components/Accordion/Accordion.tsx 65.3% <100%> (+0.72%) ⬆️
packages/react/src/components/List/List.tsx 71.23% <100%> (+0.39%) ⬆️
...ges/react/src/components/RadioGroup/RadioGroup.tsx 95.16% <100%> (+0.07%) ⬆️
packages/react/src/components/Tree/Tree.tsx 75% <100%> (+0.58%) ⬆️
packages/react/src/components/Form/Form.tsx 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044717d...839de31. Read the comment docs.

@bmdalex bmdalex force-pushed the feat/components-align-slot-class-names branch 2 times, most recently from 82e8b8d to c8f1dcd Compare March 27, 2019 13:39
@bmdalex bmdalex force-pushed the feat/components-align-slot-class-names branch from 2fcd4f9 to 01b1965 Compare March 27, 2019 16:25
@bmdalex bmdalex merged commit 7bd7426 into master Mar 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/components-align-slot-class-names branch March 27, 2019 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants