fix: correct teams theme siteVariables#110
Conversation
sergiorv
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
mnajdova
as code owners
alinais
left a comment
alinais
left a comment
There was a problem hiding this comment.
We used to created the values of the grays in a more dynamic way, using transparentize function (transparentize($app-black, .25)). Any reasons why we want to better hardcode it?
|
We've had so many issues in the past by using transparency in colors, Design has determined that solid colors will work better across Teams UI.
|
| const blackRgbaFormat = (alpha: number): string => `rgba(37, 36, 36, ${alpha})` | ||
| export const black = blackRgbaFormat(1) | ||
| const blackRgbaFormat = (alpha: number): string => `rgba(37, 36, 35, ${alpha})` | ||
| export const black = '#252423' |
There was a problem hiding this comment.
Can we consolidate black and fontBlack?
There was a problem hiding this comment.
Done, I've also removed app-gray-12 since it will be removed in the near future anyway.
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 67.78% 67.71% -0.08%
==========================================
Files 101 101
Lines 1366 1363 -3
Branches 261 261
==========================================
- Hits 926 923 -3
Misses 438 438
Partials 2 2
Continue to review full report at Codecov.
|
src/themes/teams/siteVariables.ts
Outdated
| export const black = blackRgbaFormat(1) | ||
| const blackRgbaFormat = (alpha: number): string => `rgba(37, 36, 35, ${alpha})` | ||
| export const black = '#252423' | ||
| export const gray01 = blackRgbaFormat(0.95) |
There was a problem hiding this comment.
just out of curiosity - could you, please, suggest why this one remains to be the only which uses transparency instead of solid color?
levithomason
changed the title
|
@sergiorv this is ready for merge once tests pass 👍 |
5 participants
Updating the black color and changing the grays from colors with transparency to solid colors.
The rest of the colors are up to date with the Teams palette.