This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(menu): Remove Children API examples#111
Merged
miroslavstastny merged 2 commits intomasterfrom Aug 20, 2018
Merged
Conversation
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 39 39
Lines 667 667
Branches 102 102
=======================================
Hits 574 574
Misses 90 90
Partials 3 3Continue to review full report at Codecov.
|
alinais
approved these changes
Aug 20, 2018
Contributor
alinais
left a comment
alinais
left a comment
There was a problem hiding this comment.
Let's sync with the team and @levithomason to decide whether we'd like to remove the children handling at all for Menu component.
Meantime, this PR looks good to me.
kuzhelov
approved these changes
Aug 20, 2018
Contributor
kuzhelov
left a comment
kuzhelov
left a comment
There was a problem hiding this comment.
please, just add changes to CHANGELOG and we can merge 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu
Removes all Children API examples for
Menucomponent as these are currently unsupported and broken.TODO