This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Merged
Conversation
added 2 commits
March 27, 2019 16:33
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
sophieH29
approved these changes
Mar 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
==========================================
+ Coverage 82.33% 82.35% +0.02%
==========================================
Files 730 732 +2
Lines 8684 8696 +12
Branches 1167 1233 +66
==========================================
+ Hits 7150 7162 +12
Misses 1519 1519
Partials 15 15
Continue to review full report at Codecov.
|
bmdalex
approved these changes
Mar 29, 2019
Collaborator
bmdalex
left a comment
bmdalex
left a comment
There was a problem hiding this comment.
👍 looks good to me, pls add CHANGELOG entry before merge and couple of examples if you feel it's valuable
packages/react/src/lib/accessibility/Behaviors/Alert/alertBehavior.ts
Outdated
Show resolved
Hide resolved
packages/react/src/lib/accessibility/Behaviors/Alert/alertInfoBehavior.ts
Outdated
Show resolved
Hide resolved
packages/react/src/lib/accessibility/Behaviors/Alert/alertWarningBehavior.ts
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Mar 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds role=alert or status (depending on the variant) and aria-live=polite to the root slot