This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icon): export ban and exclamation-circle in Teams theme#1123
Merged
feat(Icon): export ban and exclamation-circle in Teams theme#1123
ban and exclamation-circle in Teams theme#1123Conversation
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
+ Coverage 82.03% 82.05% +0.02%
==========================================
Files 722 724 +2
Lines 8609 8619 +10
Branches 1169 1169
==========================================
+ Hits 7062 7072 +10
Misses 1530 1530
Partials 17 17
Continue to review full report at Codecov.
|
codepretty
reviewed
Mar 28, 2019
| </svg> | ||
| ), | ||
| styles: {}, | ||
| exportedAs: 'block', |
Collaborator
There was a problem hiding this comment.
Should we export as "ban", like font awesome?
Contributor
Author
There was a problem hiding this comment.
will do that, thanks!
codepretty
approved these changes
Mar 28, 2019
Collaborator
codepretty
left a comment
codepretty
left a comment
There was a problem hiding this comment.
Looks good - with one more suggestion... consider exporting the input-invalid to exclamation-circle as well.
kuzhelov
changed the title
block and input-invalid in Teams themeban and exclamation-circle in Teams theme
delete-merged-branch
bot
deleted the
feat/export-block-and-input-invalid-icons
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO