This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(accessibility): add missing types to role#1126
Merged
layershifter merged 2 commits intomasterfrom Mar 29, 2019
Merged
Conversation
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
=======================================
Coverage 82.05% 82.05%
=======================================
Files 724 724
Lines 8619 8619
Branches 1169 1234 +65
=======================================
Hits 7072 7072
Misses 1530 1530
Partials 17 17
Continue to review full report at Codecov.
|
miroslavstastny
approved these changes
Mar 29, 2019
Member
miroslavstastny
left a comment
miroslavstastny
left a comment
There was a problem hiding this comment.
Live Region Roles are ok 👍
But going through wai-aria-1.1, I see several roles missing or being in a wrong group.
Missing roles: alertdialog, cell, feed, figure, rowgroup, searchbox, table, term.
@jurokapsiar
…om/stardust-ui/react into fix/types-aria-role # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #630.