This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(what-input): add functionality for changing the currentInput#1151
Merged
feat(what-input): add functionality for changing the currentInput#1151
Conversation
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1151 +/- ##
==========================================
- Coverage 82.4% 82.38% -0.02%
==========================================
Files 733 733
Lines 8717 8720 +3
Branches 1230 1230
==========================================
+ Hits 7183 7184 +1
- Misses 1519 1521 +2
Partials 15 15
Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Apr 2, 2019
sophieH29
approved these changes
Apr 2, 2019
layershifter
approved these changes
Apr 2, 2019
mnajdova
changed the title
kuzhelov
approved these changes
Apr 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs adds reset functinality for the what input service, and is used in the Popup. It fixes existing bug in the Popup using the popupFocusTrapBehavior together with the on='hover' prop.
Previously:
After:
