Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(Reaction): add styles for dark and hoc Teams theme#1152

Merged
mnajdova merged 7 commits intomasterfrom
feat/reactions-red-line
Apr 8, 2019
Merged

feat(Reaction): add styles for dark and hoc Teams theme#1152
mnajdova merged 7 commits intomasterfrom
feat/reactions-red-line

Conversation

@mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Apr 2, 2019

This PR adds updates on the Reactions component in dark and hoc Teams themes, and adds the new focus indicator.
Light theme:
image

Dark theme:
image

HOC:
image

The pictures are taken from the Prototypes for the ChatMessages.

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #1152 into master will decrease coverage by 0.02%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
- Coverage   82.48%   82.46%   -0.03%     
==========================================
  Files         733      735       +2     
  Lines        8717     8724       +7     
  Branches     1232     1235       +3     
==========================================
+ Hits         7190     7194       +4     
- Misses       1511     1514       +3     
  Partials       16       16
Impacted Files Coverage Δ
...mes/teams/components/Reaction/reactionVariables.ts 100% <ø> (ø) ⬆️
...themes/teams/components/Reaction/reactionStyles.ts 33.33% <0%> (-11.12%) ⬇️
...eams-dark/components/Reaction/reactionVariables.ts 100% <100%> (ø)
.../react/src/themes/teams-dark/componentVariables.ts 100% <100%> (ø) ⬆️
...-contrast/components/Reaction/reactionVariables.ts 100% <100%> (ø)
...c/themes/teams-high-contrast/componentVariables.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adb950...3d06500. Read the comment docs.

@mnajdova mnajdova changed the title [WIP] feat(Reaction): add styles for dark and hoc Teams theme feat(Reaction): add styles for dark and hoc Teams theme Apr 2, 2019
@mnajdova mnajdova merged commit 90c5859 into master Apr 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/reactions-red-line branch April 8, 2019 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants