Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(Alert): imports#1159

Merged
miroslavstastny merged 2 commits intomasterfrom
fix/alert-import
Apr 3, 2019
Merged

fix(Alert): imports#1159
miroslavstastny merged 2 commits intomasterfrom
fix/alert-import

Conversation

@mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Apr 3, 2019

No description provided.

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #1159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         733      733           
  Lines        8720     8720           
  Branches     1230     1230           
=======================================
  Hits         7184     7184           
  Misses       1521     1521           
  Partials       15       15
Impacted Files Coverage Δ
packages/react/src/components/Alert/Alert.tsx 100% <ø> (ø) ⬆️
...rc/themes/teams/components/Alert/alertVariables.ts 50% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c786eb2...962ea01. Read the comment docs.

@layershifter
Copy link
Member

layershifter commented Apr 3, 2019

I suggest to find the issue before merge why it was not captured by our project tests (Create React App with TS).

@miroslavstastny
Copy link
Member

I suggest to find the issue before merge why it was not captured by our project tests (Create React App with TS).

Let's merge it first to have healthy master, and analyse the tests separately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants