This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(dropdown): truncate the header and content#1161
Merged
silviuaavram merged 4 commits intomasterfrom Apr 5, 2019
Merged
Conversation
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1161 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 733 733
Lines 8720 8720
Branches 1165 1230 +65
=======================================
Hits 7184 7184
Misses 1521 1521
Partials 15 15
Continue to review full report at Codecov.
|
kuzhelov
approved these changes
Apr 3, 2019
Contributor
kuzhelov
left a comment
kuzhelov
left a comment
There was a problem hiding this comment.
please, don't forget about changelog entry
silviuaavram
force-pushed
the
fix-dropdownitem-truncate-text
branch
from
d25342c to
33584d5
Compare
sophieH29
approved these changes
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncates the text content and header for
DropdownItemby supplying appropriate props toListItem.