Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

chore(tslib): optimize imports#1184

Merged
layershifter merged 5 commits intomasterfrom
chore/tsconfig-use-tslib
Apr 9, 2019
Merged

chore(tslib): optimize imports#1184
layershifter merged 5 commits intomasterfrom
chore/tsconfig-use-tslib

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Apr 8, 2019

This PR adds importHelpers option and allows us to drastically reduce bundle size 🚀 It will import emit helpers (e.g. __extends, __rest, etc..) from tslib, similar to @babel/runtime.


Measures are taken from our UMD bundle as it contains all components.

Before: 723KB
After: 681KB (-42KB/-~6%)

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #1184 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1184   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files         740      740           
  Lines        8754     8754           
  Branches     1170     1236   +66     
=======================================
  Hits         7220     7220           
  Misses       1519     1519           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783c783...e71c020. Read the comment docs.

@layershifter layershifter changed the title WIP: chore(tslib): optimize imports chore(tslib): optimize imports Apr 8, 2019
@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Apr 8, 2019

Warnings
⚠️ Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies in packages/react/package.json

package before after
tslib - ^1.9.3

Changed dependencies in packages/react-component-nesting-registry/package.json

package before after
tslib - ^1.9.3

Changed dependencies in packages/react-proptypes/package.json

package before after
tslib - ^1.9.3

Changed dependencies in packages/react-component-event-listener/package.json

package before after
tslib - ^1.9.3

Generated by 🚫 dangerJS

@layershifter layershifter merged commit ddbe58e into master Apr 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/tsconfig-use-tslib branch April 9, 2019 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants