This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Chat Message): update at mention colors#1232
Merged
codepretty merged 8 commits intomasterfrom Apr 20, 2019
Merged
Conversation
codepretty
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
=======================================
Coverage 71.57% 71.57%
=======================================
Files 730 730
Lines 5579 5579
Branches 1634 1612 -22
=======================================
Hits 3993 3993
Misses 1581 1581
Partials 5 5
Continue to review full report at Codecov.
|
mnajdova
reviewed
Apr 17, 2019
CHANGELOG.md
Outdated
| - Fix overflowing focus outline for `Grid` items for Teams theme @Bugaa92 ([#1195](https://github.com/stardust-ui/react/pull/1195)) | ||
| - Fix routing for accessibility documentation @sophieH29 ([#1208](https://github.com/stardust-ui/react/pull/1208)) | ||
| - Fix `content` prop type in `Dialog` @layershifter ([#1212](https://github.com/stardust-ui/react/pull/1212)) | ||
| - Fix themeing for at mention nubbin and left bar in `ChatMessage` @codepretty ([#1232](https://github.com/stardust-ui/react/pull/1232)) |
Contributor
There was a problem hiding this comment.
Add in the changelog entry in Teams theme
mnajdova
approved these changes
Apr 17, 2019
alinais
approved these changes
Apr 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The at mention color for the bar should be different from the at mention nubbin color. The nubbin and bar colors for high contrast should all be yellow.
Teams default
Teams dark
Teams contrast
