This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Adding keyboard enter and spacebar functionality for the Tree component#1233
Merged
priyankar205 merged 9 commits intomasterfrom Apr 17, 2019
Merged
Adding keyboard enter and spacebar functionality for the Tree component#1233priyankar205 merged 9 commits intomasterfrom
priyankar205 merged 9 commits intomasterfrom
Conversation
Collaborator
priyankar205
commented
Apr 17, 2019
priyankar205
commented
- Added open & close subtree functionality (for accessibility) from keyboard.
priyankar205
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
- Coverage 83.21% 83.19% -0.03%
==========================================
Files 754 754
Lines 8913 8918 +5
Branches 1194 1194
==========================================
+ Hits 7417 7419 +2
- Misses 1482 1485 +3
Partials 14 14
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
- Coverage 83.21% 83.19% -0.02%
==========================================
Files 754 754
Lines 8912 8916 +4
Branches 1262 1194 -68
==========================================
+ Hits 7416 7418 +2
- Misses 1482 1484 +2
Partials 14 14
Continue to review full report at Codecov.
|
sophieH29
reviewed
Apr 17, 2019
sophieH29
reviewed
Apr 17, 2019
sophieH29
approved these changes
Apr 17, 2019
sophieH29
approved these changes
Apr 17, 2019
delete-merged-branch
bot
deleted the
priyankar/tree-keyboard-accessibility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.