This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Accessibility): Add roles to Popup's content in accessibility behavior#1253
Merged
feat(Accessibility): Add roles to Popup's content in accessibility behavior#1253
Conversation
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1253 +/- ##
=======================================
Coverage 71.91% 71.91%
=======================================
Files 731 731
Lines 5591 5591
Branches 1612 1612
=======================================
Hits 4021 4021
Misses 1565 1565
Partials 5 5
Continue to review full report at Codecov.
|
kuzhelov
approved these changes
Apr 23, 2019
jurokapsiar
approved these changes
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances accessibility behaviors by setting correct role
popupBehavior- role="complementary"popupFocusTrapBehavior- role="dialog"