Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(Icons): Adding new callings & meetings icons#1264

Merged
codepretty merged 8 commits intomasterfrom
feat/add-calling-icons
May 7, 2019
Merged

feat(Icons): Adding new callings & meetings icons#1264
codepretty merged 8 commits intomasterfrom
feat/add-calling-icons

Conversation

@codepretty
Copy link
Collaborator

@codepretty codepretty commented Apr 24, 2019

New icons added for calling scenarios

image


Addresses this issue #1278

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1264 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   72.79%   72.83%   +0.04%     
==========================================
  Files         738      747       +9     
  Lines        5645     5654       +9     
  Branches     1655     1633      -22     
==========================================
+ Hits         4109     4118       +9     
  Misses       1529     1529              
  Partials        7        7
Impacted Files Coverage Δ
...g/ProcessedIcons/icons-call-participant-onhold.tsx 100% <ø> (ø) ⬆️
...onents/Icon/svg/ProcessedIcons/icons-call-hold.tsx 100% <ø> (ø) ⬆️
.../Icon/svg/ProcessedIcons/icons-blur-background.tsx 100% <ø> (ø) ⬆️
...ts/Icon/svg/ProcessedIcons/icons-call-transfer.tsx 100% <ø> (ø) ⬆️
...es/teams/components/Icon/svg/icons/callParking.tsx 100% <100%> (ø)
...mes/teams/components/Icon/svg/icons/pauseThick.tsx 100% <100%> (ø)
...mes/teams/components/Icon/svg/icons/phoneArrow.tsx 100% <100%> (ø)
...emes/teams/components/Icon/svg/icons/userPhone.tsx 100% <100%> (ø)
...components/Icon/svg/icons/callControlCloseTray.tsx 100% <100%> (ø)
...mes/teams/components/Icon/svg/icons/screencast.tsx 100% <100%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eac364...5785602. Read the comment docs.

@codepretty codepretty changed the title [wip] feat(Icons): Adding new callings & meetings icons feat(Icons): Adding new callings & meetings icons May 2, 2019
@layershifter
Copy link
Member

  • call-park - nit, call-parking because park is large public garden or area of land used for recreation
  • call-control-present - I want to mention that we also have call-control-present-new
  • cast - I suggest video-cast or screen-cast becase FA has podcast
  • pause-thick should be a variation of pause, but we don't have such option yet
  • user-phone - not, sure, we have there control/screen, user & phone
  • close-share-tray - call-control-present-new is opposite to this icon?
  • user-friends - just users?

@codepretty
Copy link
Collaborator Author

codepretty commented May 7, 2019

  • cast - I suggest video-cast or screen-cast becase FA has podcast

I like screen-cast

  • call-control-present - I want to mention that we also have call-control-present-new
  • close-share-tray - call-control-present-new is opposite to this icon?

what i'd really like to do is rename all of these to something more generic. these are all very non-intuitive. I think these would be better named to something like screen-arrow-up and screen-x, but i'm not sure we should rename icons and cause potential regressions?
image

  • pause-thick should be a variation of pause, but we don't have such option yet

should we delay adding this?

  • user-phone - not, sure, we have there control/screen, user & phone

any ideas?? @levithomason

  • user-friends - just users?

we have a teams icon that i think should really be users. i agree that user-friends is confusing, it's just what i found FA doing, but not sure that justifies here

@layershifter
Copy link
Member

I like screen-cast

Only one thing, as I see screencast is a single word :) https://en.wikipedia.org/wiki/Screencast

what i'd really like to do is rename all of these to something more generic.

Let's leave it as it it now.

should we delay adding this?

Nope, because we don't have any ETA for #1039 :(

@codepretty codepretty merged commit a6c4ed7 into master May 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/add-calling-icons branch May 7, 2019 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants