This repository was archived by the owner on Mar 4, 2020. It is now read-only.
test: add missing mergeThemes export tests#128
Merged
levithomason merged 1 commit intomasterfrom Aug 24, 2018
Merged
Conversation
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 47 47
Lines 774 774
Branches 101 101
=======================================
Hits 684 684
Misses 87 87
Partials 3 3Continue to review full report at Codecov.
|
levithomason
force-pushed
the
test/merge-themes
branch
from
46d7025 to
5623bf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a bug when passing a partial
themethat does not containcomponentVariablesto theProvider. TheProviderthrows as it tries to merge keys that don't exist.This PR fixes that small bug and also adds full test coverage to
mergeThemesand all of its exports./cc @miroslavstastny this includes the fixes and tests from #106 plus many more. I also addressed your comments here regarding using
mergeComponentVariablesdirectly and breaking Header's variables. There are now tests for this usage as well.This PR seems to have fixed 4 previously broken Header examples showing the
descriptionprop where color was not being applied:...merging as this is blocking my work in getting started documentation.