Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

docs(Slots): Clearly identify Slots in DocSite#1292

Merged
alinais merged 8 commits intomasterfrom
hueland/identify-slots
May 17, 2019
Merged

docs(Slots): Clearly identify Slots in DocSite#1292
alinais merged 8 commits intomasterfrom
hueland/identify-slots

Conversation

@hughreeling
Copy link
Contributor

@hughreeling hughreeling commented May 6, 2019

Identify slot properties explicitly and mark with blue 'S'

image

Add ref to Shorthand page.

image

Identified explicitly in code:
image

@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #1292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1292   +/-   ##
=======================================
  Coverage   72.29%   72.29%           
=======================================
  Files         762      762           
  Lines        5767     5767           
  Branches     1688     1712   +24     
=======================================
  Hits         4169     4169           
  Misses       1592     1592           
  Partials        6        6
Impacted Files Coverage Δ
packages/react/src/components/Button/Button.tsx 90.9% <ø> (ø) ⬆️
packages/react/src/components/Dialog/Dialog.tsx 36.11% <ø> (ø) ⬆️
packages/react/src/components/Loader/Loader.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b74fb...5543454. Read the comment docs.

@hughreeling hughreeling changed the title POC - Clearly identify Slots in DocSite Clearly identify Slots in DocSite May 7, 2019
@alinais alinais changed the title Clearly identify Slots in DocSite docs(Slots): Clearly identify Slots in DocSite May 17, 2019
@alinais alinais merged commit 65f4f93 into master May 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the hueland/identify-slots branch May 17, 2019 15:19
@alinais alinais restored the hueland/identify-slots branch May 17, 2019 15:20
@alinais alinais deleted the hueland/identify-slots branch May 17, 2019 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants